Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11770

preserve kernel API when T10-PI patches are applied

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.13.0, Lustre 2.12.4
    • Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      Preserve the existing kernel API when the T10-PI patches are applied, so that any other modules using this interface do not break.

      In particular, keep the EXPORT_SYMBOL(bio_integrity_alloc) and EXPORT_SYMBOL(bio_integrity_prep) in place.

      In struct bio_integrity_payload put *bip_generate_fn and *bip_verify_fn after *bip_vec since that field is directly accessed by callers. In struct blk_integrity_exchg the bi_idx field only needs to be an unsigned short since the bio->bi_idx and bio->bi_vcnt values used with it are also unsigned short, which saves 8 bytes of padding in the struct and puts the added fields at the end to preserve the structure field alignment.

      Attachments

        Issue Links

          Activity

            [LU-11770] preserve kernel API when T10-PI patches are applied
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.12.4 [ 14690 ]
            Fix Version/s Original: Lustre 2.12.1 [ 14406 ]
            dongyang Dongyang Li made changes -
            Link New: This issue is related to EX-361 [ EX-361 ]
            mdiep Minh Diep made changes -
            Fix Version/s New: Lustre 2.12.1 [ 14406 ]
            mdiep Minh Diep made changes -
            Labels Original: LTS12
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.13.0 [ 14290 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            dongyang Dongyang Li made changes -
            Link New: This issue is related to LU-11822 [ LU-11822 ]
            adilger Andreas Dilger made changes -
            Labels New: LTS12
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-11712 [ LU-11712 ]
            adilger Andreas Dilger made changes -
            Affects Version/s New: Lustre 2.12.0 [ 13495 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-10472 [ LU-10472 ]
            adilger Andreas Dilger created issue -

            People

              adilger Andreas Dilger
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: