Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11796

Remove LASSERT(r0->lo_nr <= lov_targets_nr(dev)) in maintenance branches

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.13.0, Lustre 2.12.3
    • Lustre 2.12.0, Lustre 2.10.6
    • None
    • 3
    • 9223372036854775807

    Description

      In reviewing the overstriping patch, Andreas noted that one assert it's removing should also be removed in the maintenance branches:

      https://review.whamcloud.com/#/c/28425/15/lustre/lov/lov_object.c

      This is because the client is asserting on network data from the server, and the assert is enforcing an expected constraint (num stripes <= num osts), but nothing goes wrong if it's removed.  In fact, it might be possible for the two to disagree if OSTs go offline.

      Attachments

        Activity

          [LU-11796] Remove LASSERT(r0->lo_nr <= lov_targets_nr(dev)) in maintenance branches

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34918/
          Subject: LU-11796 lov: Remove unnecessary assert
          Project: fs/lustre-release
          Branch: b2_12
          Current Patch Set:
          Commit: 7f9393e1ea280f45b8400f5da2cbe41a3b908872

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34918/ Subject: LU-11796 lov: Remove unnecessary assert Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 7f9393e1ea280f45b8400f5da2cbe41a3b908872

          Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34918
          Subject: LU-11796 lov: Remove unnecessary assert
          Project: fs/lustre-release
          Branch: b2_12
          Current Patch Set: 1
          Commit: 9560a93dac848fa6afa758bcd377cb9d5b519da0

          gerrit Gerrit Updater added a comment - Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34918 Subject: LU-11796 lov: Remove unnecessary assert Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 9560a93dac848fa6afa758bcd377cb9d5b519da0
          pjones Peter Jones added a comment -

          Landed for 2.13

          pjones Peter Jones added a comment - Landed for 2.13

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33882/
          Subject: LU-11796 lov: Remove unnecessary assert
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 1d71044851192ee36f0841b525d3df0e3b054794

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33882/ Subject: LU-11796 lov: Remove unnecessary assert Project: fs/lustre-release Branch: master Current Patch Set: Commit: 1d71044851192ee36f0841b525d3df0e3b054794

          Patrick Farrell (paf@cray.com) uploaded a new patch: https://review.whamcloud.com/33882
          Subject: LU-11796 lov: Remove unnecessary assert
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 39e110caac0f72505c962615c5f561316e2e35bc

          gerrit Gerrit Updater added a comment - Patrick Farrell (paf@cray.com) uploaded a new patch: https://review.whamcloud.com/33882 Subject: LU-11796 lov: Remove unnecessary assert Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 39e110caac0f72505c962615c5f561316e2e35bc

          People

            paf Patrick Farrell (Inactive)
            paf Patrick Farrell (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: