[LU-11839] iokit-gather-stats help message woks with ‘-h’ or ‘--help’ not ‘-help’

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Affects Version/s: Lustre 2.12.0, Lustre 2.13.0
• Labels: easy
• Assignee: Arshad Hussain
• Reporter: James Nunez (Inactive)

Description

Running iokit-gather-stats with no flags results in

#  /usr/bin/iokit-gather-stats
Usage: iokit-gather-stats [-help] config_file [start|stop|cleanup] <log_name>

So, to get help on the command, we should use the ‘-help’ flag

#  /usr/bin/iokit-gather-stats -help
getopt: invalid option -- 'e'
getopt: invalid option -- 'l'
getopt: invalid option -- 'p'
Usage: iokit-gather-stats [-help] config_file [start|stop|cleanup] <log_name>

Well, that didn’t help.

Looking at the code, we should really use ‘h’ or ‘-help’. Thus, we should modify the Usage statement above.

Comments

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43114/
Subject: LU-11839 iokit: Fix help message
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b8ef80984140201bb4b994ee745757f07ad5f832

[Gerrit Updater]

Arshad Hussain ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43114
Subject: LU-11839 iokit: Fix help message
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c58ef43f90f63cdfbb2f41db0d4a65c202b24861