[LU-11914] Build error for l_getsepol.c due to missing openssl/evp.h

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.2
• Affects Version/s: Lustre 2.13.0
• Labels: llnl
• Environment: RHEL7.5 without openssl-devel
• Assignee: Sebastien Buisson
• Reporter: Andreas Dilger

Description

I got a build failure due to a missing header for the newly-added l_getsepol command:

l_getsepol.c:50:25: fatal error: openssl/evp.h: No such file or directory
#include <openssl/evp.h>

This requires the openssl-devel package to be installed in order to build, but that is not in the BuildRequires of lustre.spec file. Also, for sites that don't need this utility, the configure check should disable building l_getsepol if the header is not available.

Finally, there is no l_getsepol.8 man page in lustre/doc for this command.

Issue Links

• is related to: LU-17226 l_getsepol does not build due to not requiring openssl-devel
• is related to: LU-11960 Add missing libssl-dev DEB package
• is related to: LU-8955 Send SELinux policy info to server

Comments

[Peter Jones]

I think that we set now

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34832/
Subject: LU-11914 build: add a configure check for l_getsepol
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 68fc8296a7f6889bdb3401b476ef2af555c90a99

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34832
Subject: LU-11914 build: add a configure check for l_getsepol
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 00bac8c71132c579e881031fd6e66c68967b11af

[Olaf Faaland]

The man page addition also did not get backported to 2.12.1, I believe.

[Olaf Faaland]

Some of the SELinux related patches, such as

LU-8955 sec: create new function sptlrpc_get_sepol()

were backported to b2_12 for Lustre 2.12.1, but this patch was not, and so 2.12.1 has this build issue.

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34183/
Subject: LU-11914 build: add a configure check for l_getsepol
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: be6de3db9cace327b3d34870417c96c2ac705313

[Sebastien Buisson]

The man page for l_getsepol has been submitted under LU-930:
https://review.whamcloud.com/34184

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34183
Subject: LU-11914 build: add a configure check for l_getsepol
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e896ef5214f9f1fd22096c259822df81531a3a4f

[Sebastien Buisson]

I will add a configure check that disables building l_getsepol in case openssl-devel is not available.

But in this case, I do not see the point of adding a BuildRequires directive into the spec file: thanks to the configure check, there will be no hard dependency.