Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Looking at:

      https://testing.whamcloud.com/test_sets/a9c1ab0e-2d95-11e9-b3df-52540065bddc

       

      We see that when test_93 fails, test_98 also fails because the system is not in the expected state.  Most tests in conf-sanity assume the state is "cleaned up" when they start, but most of them also don't cleanup correctly on errors.

       

      Adding cleanup to CLEANUP so it's run after every test, guaranteed, can fix most of this.

      Attachments

        Issue Links

          Activity

            [LU-11953] Add cleanup to conf-sanity

            I've been wondering if conf-sanity needs a bit of an overhaul, to separate between subtests that expect the filesystem to be mounted at the start and subtests that expect to format the filesystem in a particular configuration. In the latter case it seems like we are doing a lot of extra effort to reformat the filesystem at the end of the subtest.

            It would be useful to see whether it would be a net improvement to just leave the filesystem unmounted at the end of the conf-sanity subtests and they are responsible for doing their own configuration.

            adilger Andreas Dilger added a comment - I've been wondering if conf-sanity needs a bit of an overhaul, to separate between subtests that expect the filesystem to be mounted at the start and subtests that expect to format the filesystem in a particular configuration. In the latter case it seems like we are doing a lot of extra effort to reformat the filesystem at the end of the subtest. It would be useful to see whether it would be a net improvement to just leave the filesystem unmounted at the end of the conf-sanity subtests and they are responsible for doing their own configuration.

            Patrick Farrell (pfarrell@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34224
            Subject: LU-11953 tests: conf-sanity setup
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ee665b37c0fa766fd85912687fbc7a84895335a9

            gerrit Gerrit Updater added a comment - Patrick Farrell (pfarrell@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34224 Subject: LU-11953 tests: conf-sanity setup Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ee665b37c0fa766fd85912687fbc7a84895335a9

            People

              wc-triage WC Triage
              pfarrell Patrick Farrell (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: