Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12068

sanity-lfsck test_6b: (7.2) 0x0 is not larger than 0x0

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.13.0, Lustre 2.12.2
    • Lustre 2.13.0, Lustre 2.12.1
    • 3
    • 9223372036854775807

    Description

      This issue was created by maloo for wangshilong <wshilong@ddn.com>

      This issue relates to the following test suite run: https://testing.whamcloud.com/test_sets/36dcb5b6-45d2-11e9-9646-52540065bddc

      test_6b failed with the following error:

      (7.2) 0x0 is not larger than 0x0
      

      <<Please provide additional information about the failure here>>

      VVVVVVV DO NOT REMOVE LINES BELOW, Added by Maloo for auto-association VVVVVVV
      sanity-lfsck test_6b - (7.2) 0x0 is not larger than 0x0

      Attachments

        Issue Links

          Activity

            [LU-12068] sanity-lfsck test_6b: (7.2) 0x0 is not larger than 0x0

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34696/
            Subject: LU-12068 test: compare position for ZFS dot entry
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 1e6cd6b21fc37420341fdb0dcec366bb3feb350e

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34696/ Subject: LU-12068 test: compare position for ZFS dot entry Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 1e6cd6b21fc37420341fdb0dcec366bb3feb350e

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34695/
            Subject: LU-12068 tests: add debug for sanity-lfsck test_6b
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: f5e0c311ae60709070514b951f7d25d537d3dc91

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34695/ Subject: LU-12068 tests: add debug for sanity-lfsck test_6b Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: f5e0c311ae60709070514b951f7d25d537d3dc91

            Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34696
            Subject: LU-12068 test: compare position for ZFS dot entry
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 08a0fa85c6f9987dbd6c3049b46c660a1846a1c3

            gerrit Gerrit Updater added a comment - Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34696 Subject: LU-12068 test: compare position for ZFS dot entry Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 08a0fa85c6f9987dbd6c3049b46c660a1846a1c3

            Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34695
            Subject: LU-12068 tests: add debug for sanity-lfsck test_6b
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 02ebeedf6dcd83d11e13e31c06753cfaef5dcbbf

            gerrit Gerrit Updater added a comment - Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34695 Subject: LU-12068 tests: add debug for sanity-lfsck test_6b Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 02ebeedf6dcd83d11e13e31c06753cfaef5dcbbf
            mdiep Minh Diep added a comment -

            Landed in 2.13

            mdiep Minh Diep added a comment - Landed in 2.13

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34525/
            Subject: LU-12068 test: compare position for ZFS dot entry
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 42adbae36f206a6ed4170e7619cd993c8fa80b1d

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34525/ Subject: LU-12068 test: compare position for ZFS dot entry Project: fs/lustre-release Branch: master Current Patch Set: Commit: 42adbae36f206a6ed4170e7619cd993c8fa80b1d
            mdiep Minh Diep added a comment - +1 on b2_12 https://testing.whamcloud.com/test_sets/eb96e502-5523-11e9-9646-52540065bddc
            hongchao.zhang Hongchao Zhang added a comment - - edited

            Hi Andreas,

            Yes, there is one failed case on 2019-02-20 and another one on 2019-02-25, both failed cases are on branch "master-next",
            the version is "2.12.51.85", is it possible this version contains some other patches?

            https://testing.whamcloud.com/test_sessions/ae657cad-8359-4ff5-a42a-9b0e496a025b
            https://testing.whamcloud.com/test_sessions/b49849ff-483d-4982-84c5-92721cae1afe

            hongchao.zhang Hongchao Zhang added a comment - - edited Hi Andreas, Yes, there is one failed case on 2019-02-20 and another one on 2019-02-25, both failed cases are on branch "master-next", the version is "2.12.51.85", is it possible this version contains some other patches? https://testing.whamcloud.com/test_sessions/ae657cad-8359-4ff5-a42a-9b0e496a025b https://testing.whamcloud.com/test_sessions/b49849ff-483d-4982-84c5-92721cae1afe

            The patch https://review.whamcloud.com/34098 "LU-11330 osd-zfs: hash for ./.. must be 0" only landed on 2019-02-27, while there were a few tests failing on 2019-02-20 to 2019-02-25, so it is close to the first date this problem was seen, but not exactly the same. However, most of the tests started failing after 2019-02-27 so it is possible there are a couple of different issues here, and LU-11330 made the problem much worse. There aren't any cases where this test failed during the testing of LU-11330, but it is definitely not being hit on ldiskfs so this is the likely cause of most of these failures.

            adilger Andreas Dilger added a comment - The patch https://review.whamcloud.com/34098 " LU-11330 osd-zfs: hash for ./.. must be 0 " only landed on 2019-02-27, while there were a few tests failing on 2019-02-20 to 2019-02-25, so it is close to the first date this problem was seen, but not exactly the same. However, most of the tests started failing after 2019-02-27 so it is possible there are a couple of different issues here, and LU-11330 made the problem much worse. There aren't any cases where this test failed during the testing of LU-11330 , but it is definitely not being hit on ldiskfs so this is the likely cause of most of these failures.

            The issue is managed to be reproduced locally, and the cause of it is that the LFSCK process is stopped just when it is scanning the "." or ".." entry
            of some directory, for ZFS, the position of both the two entries is zero.

            static __u64 osd_dir_it_store(const struct lu_env *env, const struct dt_it *di)
            {       
                    struct osd_zap_it *it = (struct osd_zap_it *)di;
                    __u64              pos;
                    ENTRY;
            
                    if (it->ozi_pos <= OZI_POS_DOTDOT)
                            pos = 0;
                    else
                            pos = osd_zap_cursor_serialize(it->ozi_zc);
                                              
                    RETURN(pos);
            }       
            

            the patch is tracked at https://review.whamcloud.com/34525

            hongchao.zhang Hongchao Zhang added a comment - The issue is managed to be reproduced locally, and the cause of it is that the LFSCK process is stopped just when it is scanning the "." or ".." entry of some directory, for ZFS, the position of both the two entries is zero. static __u64 osd_dir_it_store(const struct lu_env *env, const struct dt_it *di) { struct osd_zap_it *it = (struct osd_zap_it *)di; __u64 pos; ENTRY; if (it->ozi_pos <= OZI_POS_DOTDOT) pos = 0; else pos = osd_zap_cursor_serialize(it->ozi_zc); RETURN(pos); } the patch is tracked at https://review.whamcloud.com/34525

            People

              hongchao.zhang Hongchao Zhang
              maloo Maloo
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: