[LU-12101] lctl push causes a crash

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0
• Affects Version/s: Upstream
• Environment: Tested on SLE15 + Lustre 2.11, and drivers/staging.
• Severity: 3
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

The command:

lctl --net tcp push

will cause a host with any active lustre connections to crash.  Code in ksocknal_push() has an incorrect termination condition and falls off the end of a linked lists, dereferencing an invalid pointer.

Precise results vary.  e.g. an LASSERT failure in ksocknal_connsock_addref(), or a NULL pointer dereference.