Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12191

lctl list_param -R does not display everything

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.14.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      While testing lnet sysfs patches, it is found that  lctl list_param -R does not display everything under sysfs tree.

      The lnet-sysfs hierarchy is something like - 
      /sys/fs/lnet/net/o2ib1/ib0

      But lctl list_param -R does not display anything beyond
      /sys/fs/lnet/net

      This is because of the below code in param_display function in  - 

      tmp = strstr(paths.gl_pathv[i], param_name);

      Here instead of param_name, it should be /param_name/

      Attachments

        Activity

          [LU-12191] lctl list_param -R does not display everything
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.14.0 [ 14490 ]
          Assignee Original: WC Triage [ wc-triage ] New: James A Simmons [ simmonsja ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.14

          pjones Peter Jones added a comment - Landed for 2.14
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36852/
          Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 45d71469226485c7bb348ffcb1700667c1fb2fa2

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36852/ Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree Project: fs/lustre-release Branch: master Current Patch Set: Commit: 45d71469226485c7bb348ffcb1700667c1fb2fa2
          gerrit Gerrit Updater added a comment -

          James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/36852
          Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: a7db1acd2af8dfaea9032c55f10f67ec62095954

          gerrit Gerrit Updater added a comment - James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/36852 Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: a7db1acd2af8dfaea9032c55f10f67ec62095954
          gerrit Gerrit Updater added a comment -

          Sonia Sharma (sharmaso@whamcloud.com) merged in patch https://review.whamcloud.com/34693/
          Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
          Project: fs/lustre-release
          Branch: lnet-sysfs
          Current Patch Set:
          Commit: 797eff1f3f7accbbc6a3e40602eddd0122302587

          gerrit Gerrit Updater added a comment - Sonia Sharma (sharmaso@whamcloud.com) merged in patch https://review.whamcloud.com/34693/ Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree Project: fs/lustre-release Branch: lnet-sysfs Current Patch Set: Commit: 797eff1f3f7accbbc6a3e40602eddd0122302587
          gerrit Gerrit Updater added a comment -

          Sonia Sharma (sharmaso@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34693
          Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
          Project: fs/lustre-release
          Branch: lnet-sysfs
          Current Patch Set: 1
          Commit: b4527efe43d15440b8fe04a46084789f5e2244c2

          gerrit Gerrit Updater added a comment - Sonia Sharma (sharmaso@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34693 Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree Project: fs/lustre-release Branch: lnet-sysfs Current Patch Set: 1 Commit: b4527efe43d15440b8fe04a46084789f5e2244c2
          sharmaso Sonia Sharma (Inactive) made changes -
          Description Original: While testing lnet sysfs patches, it is found that{{ lctl list_param -R}} does not display everything under sysfs tree.

          The lnet-sysfs hierarchy is something like - 
          {{/sys/fs/lnet/net/o2ib1/ib0}}

          But {{lctl list_param -R}} does not display anything beyond
          {{/sys/fs/lnet/net}}

          This is because of the below code in param_display function in  - 
          {code:java}
          tmp = strstr(paths.gl_pathv[i], param_name);
          {code}
          Here instead of {{param_name}}, it should be "/'param_name/'           		New: While testing lnet sysfs patches, it is found that  {{lctl list_param -R}} does not display everything under sysfs tree.

          The lnet-sysfs hierarchy is something like - 
           {{/sys/fs/lnet/net/o2ib1/ib0}}

          But {{lctl list_param -R}} does not display anything beyond
           {{/sys/fs/lnet/net}}

          This is because of the below code in param_display function in  - 
          {code:java}
          tmp = strstr(paths.gl_pathv[i], param_name);
          {code}
          Here instead of {{param_name}}, it should be /param_name/
          sharmaso Sonia Sharma (Inactive) created issue -

          People

            simmonsja James A Simmons
            sharmaso Sonia Sharma (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: