[LU-12264] The lnet peer discovery queue (lnet_peer.lp_dc_pendq) is susceptible to concurrent manipulation

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
• Affects Version/s: Lustre 2.13.0, Lustre 2.12.2
• Severity: 3
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

This issue was discovered while testing the MR routing feature, but the bug exists in, at least, master and b2_12 as well.

On an initial call to lnet_select_pathway(), messages are added to a peer's discovery queue only under protection of lnet_net_lock_current(). If two threads are sending to the same peer, but that peer is pending discovery, and the two threads are on different CPTs, then it is possible for them to perform the list add at the same time. This can result in corruption of the list.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36037/
Subject: LU-12264 lnet: Protect lp_dc_pendq manipulation with lp_lock
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 0963d01e04e10ec09b6db045fe4110bf954d2b57

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36037
Subject: LU-12264 lnet: Protect lp_dc_pendq manipulation with lp_lock
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 84a6d4de7d664ad0248f496ee0187f88921b20f7

[Gerrit Updater]

Amir Shehata ([e-mail]) merged in patch https://review.whamcloud.com/34798/
Subject: LU-12264 lnet: Protect lp_dc_pendq manipulation with lp_lock
Project: fs/lustre-release
Branch: multi-rail
Current Patch Set:
Commit: dd16a31bf4ae874a69cc7dc5fe1f3197993630ae

[Gerrit Updater]

Chris Horn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34798
Subject: LU-12264 lnet: Protect lp_dc_pendq manipulation with lp_lock
Project: fs/lustre-release
Branch: multi-rail
Current Patch Set: 1
Commit: e1dc62e05db9b17fc0ddbe463fd68aef3eed1ff0