[LU-12333] Add additional rpc flags to DEBUG_REQ_FLAGS

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0
• Affects Version/s: Lustre 2.13.0
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

The PtlRPC state machine relies on flags in the ptlrpc_request structure to transition from one request state to another. When a request is in the RQ_PHASE_UNREG_RPC state there are three flags relevant to the request's ability to transition.

From ptlrpc_check_set():

                        if (req->rq_phase == RQ_PHASE_UNREG_RPC &&
                            ptlrpc_client_recv_or_unlink(req))
                                continue;

and from ptlrpc_client_recv_or_unlink():

        rc = !req->rq_req_unlinked || !req->rq_reply_unlinked ||
             req->rq_receiving_reply;

None of those three flags are printed by the DEBUG_REQ_FLAGS macro. Historically this has made it a little more difficult to troubleshoot bugs resulting in RPCs that are stuck in the unregistering state. Those flags should be added to the macro.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35090/
Subject: LU-12333 ptlrpc: Add more flags to DEBUG_REQ_FLAGS macro
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3e43d06810e69fdccd815bbbf5e4b50930d33ee7

[Gerrit Updater]

Vitaly Fertman ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35090
Subject: LU-12333 ptlrpc: Add more flags to DEBUG_REQ_FLAGS macro
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 56ff009c3af13deb4d249f519f7c62b8491f158b

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34949/
Subject: LU-12333 ptlrpc: Add more flags to DEBUG_REQ_FLAGS macro
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5bcc3a330e21865b5b78a4c4596f878f12a43dbc

[Andreas Dilger]

I was just thinking yesterday that it would be useful to also include the OBD device name or target name into the main client D_RPCTRACE debug messages ("Sending RPC pname:..." and ""Completed RPC pname:...") in addition to the server NID. Otherwise, in a client debug log with a large number of threads doing RPCs to servers with multiple OSTs/MDTs it is more difficult to track which target the client is accessing.

[Gerrit Updater]

Chris Horn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34949
Subject: LU-12333 ptlrpc: Add more flags to DEBUG_REQ_FLAGS macro
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 69bf6225d11745051a88f854d94a4add3f6ccb0f