[LU-12410] Refactor lnetctl peer nid handling to utilize nidstrings library

• Type: Improvement
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.14.0
• Affects Version/s: Lustre 2.13.0, Lustre 2.12.2
• Severity: 3
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

Refactoring this ticket to widen the scope a bit.

The handling of nids by lnetctl/liblnetconfig has a couple of issues. The first is incomplete support for all NID formats supported by LNet. The second is that we have some code duplication between lnetctl/liblnetconfig and the nidstrings library.

I propose to expand the nidstrings library to cover a use-case that is needed by lnetctl/liblnetconfig. Namely the expansion of a "nidrange" into a list of LNet nids.

For posterity, the original description of this ticket is below. It documents the limitation of lnetctl peer add/del in dealing with numeric NID addresses:
The nid parsing for lnetctl peer add (and delete) goes through the ip2nets path, even when the (undocumented) --ip2net option is not used. That ip2nets code does not support gnilnd because gnilnd doesn't use ip addresses. As such you cannot configure peers with gni addresses using lnetctl.

I think this should be cleaned up so that:

arguments to --prim_nid and --nid are treated as LNet nids, not "nid expressions".

"nid expressions" can only be specified via the --ip2net option.

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44188/
Subject: LU-12410 lnet: Add additional output to sanity-lnet.sh
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: a8c513b61c517f643119fe65629ab7952c7b37b4

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: https://review.whamcloud.com/44188
Subject: LU-12410 lnet: Add additional output to sanity-lnet.sh
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 459866a9806fb435345fc580c86e16b4f7474c2b

[Peter Jones]

Looks like everything has now landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35310/
Subject: LU-12410 lnet: Delete unused nid parsing code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03c4b6c8b77e8f52ea9fd1fd040d1aafbf95b470

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35506/
Subject: LU-12410 tests: Add gni tests to sanity-lnet
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6a8335be5c2bb29999d85e35d9b59ce23f025629

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35308/
Subject: LU-12410 lnet: Convert lnetctl route add and del
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 59836691cbedcf3b7912ecbed7fc286cf1d4f19f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35307/
Subject: LU-12410 lnet: Convert yaml peer configuration
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e14235f35cb6bbadb7005192fac8524077c8c7bf

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35305/
Subject: LU-12410 lnet: Convert lnetctl peer add and del
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 892f675e660a5afa0d93d883aab46bb54f107818

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35505/
Subject: LU-12410 lnet: Implement method to tokenize nidstrings
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c6e9a5d02936a215aa01021eab6d8827ceb6b19d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35504/
Subject: LU-12410 lnet: Define enum for lnetctl commands
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 04dda288a415312747ea783ef59a4a92103a3452