[LU-12527] lustreapi.h not c++ compatible

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0
• Environment: C++
• Assignee: Robert Latham
• Reporter: Robert Latham

Description

If one tries to compile a C++ program with the `lustre/lustreapi.h` header, the compiler will throw all kinds of warnings.

This issue came up on the mailing list a few years ago: http://lists.lustre.org/pipermail/lustre-discuss-lustre.org/2017-March/014268.html and I encountered it again in a different context this week. Guess not many C++ programs try to use lustreapi.h !

Comments

[Peter Jones]

Landed for 2.13 - congrats Rob!

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35471/
Subject: LU-12527 utils: Make lustre_user.h c++-legal
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 14b11dc3526ad12a138ad750ab8824b3438dc00d

[Robert Latham]

https://review.whamcloud.com/#/c/35471/

[Gerrit Updater]

Rob Latham ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35471
Subject: LU-12527 utils: Make lustre_user.h c++-legal
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e23c74817c7d1d2d2993e6a55bd4a899bfca342d

[Peter Jones]

Try now Rob

[Robert Latham]

I'm going through the process. info@whamcloud probably gets a ton of spam, but it also got a request from me asking for permission to push to gerrit.

[Peter Jones]

Rob

Thank you for the bug report and patch. Are you able to submit your patch directly to Gerrit (see http://wiki.lustre.org/Using_Gerrit for details)? If not, then we can assign this ticket to another developer, but it will likely take longer to get attention

Peter

[Robert Latham]

Here's a rough patch that makes g++ and clang++ happy.

[Robert Latham]

I attached a small C++ program to demonstrate the error. Both `clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)` and `g++ (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0` give errors.