[LU-1254] libecho still try to remove device when obdecho fail to load

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.3.0
• Severity: 3
• Assignee: Minh Diep
• Reporter: Minh Diep

Description

there is an error in libecho continue to detach device when obdecho fails to load

[root@fat-amd-3 ~]# /usr/bin/obdfilter-survey
FATAL: Could not open '/lib/modules/2.6.32-220.4.2.el6_lustre.x86_64/updates/kernel/fs/lustre/obdecho.ko': No such file or directory
FATAL: Could not open '/lib/modules/2.6.32-220.4.2.el6_lustre.x86_64/updates/kernel/fs/lustre/obdecho.ko': No such file or directory
Could not install obdecho on localhost
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
current device is -1 - not set
cleanup: please use 'device name' to set the device name for config commands.
program exited with error

with the fix.

[root@fat-amd-3 ~]# /usr/bin/obdfilter-survey
FATAL: Could not open '/lib/modules/2.6.32-220.4.2.el6_lustre.x86_64/updates/kernel/fs/lustre/obdecho.ko': No such file or directory
FATAL: Could not open '/lib/modules/2.6.32-220.4.2.el6_lustre.x86_64/updates/kernel/fs/lustre/obdecho.ko': No such file or directory
Could not install obdecho on localhost
program exited with error
[root@fat-amd-3 ~]#

the issue is

1. do cleanup and exit.
   cleanup () {
   local exit_status=$1
   local host
   case=${case:-"disk"}
   shift
   for ((i = 0; i < $ndevs; i++)); do
   host=${host_names[$i]}
   if [ -n ${do_teardown_ec[$i]} ]; then
   ^^^^ use single [] here will be true when do_teardown_ec does not exist
   teardown_ec_devno $host ${client_names[$i]}
   fi
   done

will provide a patch soon

Comments

[Build Master (Inactive)]

Integrated in lustre-dev » x86_64,client,el6,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » x86_64,server,el5,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » i686,client,el5,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » x86_64,server,el6,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » i686,server,el5,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » i686,client,el6,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-dev » x86_64,client,el5,inkernel #340
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Peter Jones]

Landed for 2.3

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #477
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,ofa #477
LU-1254 iokit: should not use single '[]' (Revision 369f9a5c41e35f63787c2c0f077df5f44048c87f)

Result = SUCCESS
Oleg Drokin : 369f9a5c41e35f63787c2c0f077df5f44048c87f
Files :

• lustre-iokit/obdfilter-survey/libecho