Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12597

test-framework mdts_nodes, osts_nodes should return comma_list

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Rank (Obsolete):
      9223372036854775807

      Description

      The test-framework.sh helper functions mdts_nodes(), osts_nodes(), agts_nodes(), nodes_list(), all_mdts_nodes(), all_osts_nodes(), all_server_nodes() and all_nodes() are mostly used together with "comma_list()" to convert the space-separated node list into a comma-separated node list suitable for use by pdsh. There are 261 uses of these functions, of which only 55 do not immediately call comma_list(),

      It makes sense to change these helper functions to call comma_list() internally to always return the comma-separated list of nodes, and fix the few places that need a space-separated list to use "| tr ',' ' '" or "${VAR//,/ }" or similar.

      It shouldn't be harmful for "comma_list()" to take an already comma-separated list as input, so there isn't a requirement for a single patch to remove the use of comma_list() from all tests, only those few places that require a space-separated list.

        Attachments

          Activity

            People

            • Assignee:
              wc-triage WC Triage
              Reporter:
              adilger Andreas Dilger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: