[LU-12597] test-framework mdts_nodes, osts_nodes should return comma_list

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: test_script_improvements
• Assignee: Andreas Dilger
• Reporter: Andreas Dilger

Description

The test-framework.sh helper functions mdts_nodes(), osts_nodes(), agts_nodes(), nodes_list(), all_mdts_nodes(), all_osts_nodes(), all_server_nodes() and all_nodes() are mostly used together with "comma_list()" to convert the space-separated node list into a comma-separated node list suitable for use by pdsh. There are 261 uses of these functions, of which only 55 do not immediately call comma_list(),

It makes sense to change these helper functions to call comma_list() internally to always return the comma-separated list of nodes, and fix the few places that need a space-separated list to use "| tr ',' ' '" or "${VAR//,/ }" or similar.

It shouldn't be harmful for "comma_list()" to take an already comma-separated list as input, so there isn't a requirement for a single patch to remove the use of comma_list() from all tests, only those few places that require a space-separated list.

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58022/
Subject: LU-12597 tests: remove comma_list for MDTs part 4
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a5d184007053d1b6a7b75e9461dab0ec4bcd7aff

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58026/
Subject: LU-12597 tests: remove comma_list for MDTs part 8
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5831fd02bf249c9af71341d7d5e0f516feb51362

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58026
Subject: LU-12597 tests: remove comma_list for MDTs part 8
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e31ab269becffa729a4c245536f2d42e8655b6ca

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58025
Subject: LU-12597 tests: remove comma_list for MDTs part 7
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7f0b616225d0e6b409c06c1b8cb9657dd996cc13

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58024
Subject: LU-12597 tests: remove comma_list for MDTs part 6
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e601cff45a71c492a7b023d89e3a190d1ba7d042

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58023
Subject: LU-12597 tests: remove comma_list for MDTs part 5
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e418f57cda7dc2397a6e5885c51870c802078ef6

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58022
Subject: LU-12597 tests: remove comma_list for MDTs part 4
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0f8ee74aa09cf47a52d200ed43b9ee6c26958bd6

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57326/
Subject: LU-12597 tests: remove comma_list for MDTs part 3
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ceee271cddc3a911a54415d7e5a125c25e6ab35b

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57325/
Subject: LU-12597 tests: remove comma_list for MDTs part 2
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 178e5b2c399a0b8adf3642eae1be705103cf5383

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/57183/
Subject: LU-12597 tests: remove comma_list for MDTs part 1
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f2642a2947d1fc109c70aadbc86c6510df9b8a34