Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12597

test-framework mdts_nodes, osts_nodes should return comma_list

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • 9223372036854775807

    Description

      The test-framework.sh helper functions mdts_nodes(), osts_nodes(), agts_nodes(), nodes_list(), all_mdts_nodes(), all_osts_nodes(), all_server_nodes() and all_nodes() are mostly used together with "comma_list()" to convert the space-separated node list into a comma-separated node list suitable for use by pdsh. There are 261 uses of these functions, of which only 55 do not immediately call comma_list(),

      It makes sense to change these helper functions to call comma_list() internally to always return the comma-separated list of nodes, and fix the few places that need a space-separated list to use "| tr ',' ' '" or "${VAR//,/ }" or similar.

      It shouldn't be harmful for "comma_list()" to take an already comma-separated list as input, so there isn't a requirement for a single patch to remove the use of comma_list() from all tests, only those few places that require a space-separated list.

      Attachments

        Activity

          [LU-12597] test-framework mdts_nodes, osts_nodes should return comma_list

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57194
          Subject: LU-12597 tests: return comma-separated mdts_nodes()
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: b69482df6f487dfca2ce40a455af19b0d6ac6829

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57194 Subject: LU-12597 tests: return comma-separated mdts_nodes() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: b69482df6f487dfca2ce40a455af19b0d6ac6829

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57183
          Subject: LU-12597 tests: remove comma_list for MDTs part 1
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: edec88b192cf905987f681200a656aa5731f1144

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57183 Subject: LU-12597 tests: remove comma_list for MDTs part 1 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: edec88b192cf905987f681200a656aa5731f1144

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57132
          Subject: LU-12597 tests: remove comma_list for OSTs part 4
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 489b21c9fdee0e16d7c0cd1eb5f4c9f4985898d2

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57132 Subject: LU-12597 tests: remove comma_list for OSTs part 4 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 489b21c9fdee0e16d7c0cd1eb5f4c9f4985898d2

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56909
          Subject: LU-12597 tests: remove comma_list for OSTs part 3
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: fcdc84a8182d897a446828ea669148c30e295be5

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56909 Subject: LU-12597 tests: remove comma_list for OSTs part 3 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fcdc84a8182d897a446828ea669148c30e295be5

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56885
          Subject: LU-12597 tests: remove comma_list for OSTs part 2
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: b95f7c9a7de725360b880c741484e9c29c133dce

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56885 Subject: LU-12597 tests: remove comma_list for OSTs part 2 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: b95f7c9a7de725360b880c741484e9c29c133dce

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56844
          Subject: LU-12597 tests: remove comma_list for OSTs part 1
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 53dad953aa2ef37dfc8d2685b95d0ad6f63b503c

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56844 Subject: LU-12597 tests: remove comma_list for OSTs part 1 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 53dad953aa2ef37dfc8d2685b95d0ad6f63b503c

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56636
          Subject: LU-12597 tests: clean up comma_list in test-framework
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: d174bd4df46bf1252884f66caba99f5dd0ed1a2f

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56636 Subject: LU-12597 tests: clean up comma_list in test-framework Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: d174bd4df46bf1252884f66caba99f5dd0ed1a2f

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56635
          Subject: LU-12597 tests: return comma-separated osts_list
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 2d0f6e11a832676d246f430f5c35b65553bdcddc

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56635 Subject: LU-12597 tests: return comma-separated osts_list Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2d0f6e11a832676d246f430f5c35b65553bdcddc

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54340/
          Subject: LU-12597 tests: allow comma-separated node lists
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: f891723d30a2b0fe4fc43d8e8e852909aae0a3e3

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54340/ Subject: LU-12597 tests: allow comma-separated node lists Project: fs/lustre-release Branch: master Current Patch Set: Commit: f891723d30a2b0fe4fc43d8e8e852909aae0a3e3

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54340
          Subject: LU-12597 tests: allow comma-separated node lists
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 40f8e9671d9dbb1b0b232c7df1796863d3620a5b

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54340 Subject: LU-12597 tests: allow comma-separated node lists Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 40f8e9671d9dbb1b0b232c7df1796863d3620a5b

          "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51976
          Subject: LU-12597 tests: remove comma_list for remaining uses
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: ac89948314ace9be89bdfe11d514d8089ed6adb4

          gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51976 Subject: LU-12597 tests: remove comma_list for remaining uses Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ac89948314ace9be89bdfe11d514d8089ed6adb4

          People

            adilger Andreas Dilger
            adilger Andreas Dilger
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: