Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
9223372036854775807
Description
The test-framework.sh helper functions mdts_nodes(), osts_nodes(), agts_nodes(), nodes_list(), all_mdts_nodes(), all_osts_nodes(), all_server_nodes() and all_nodes() are mostly used together with "comma_list()" to convert the space-separated node list into a comma-separated node list suitable for use by pdsh. There are 261 uses of these functions, of which only 55 do not immediately call comma_list(),
It makes sense to change these helper functions to call comma_list() internally to always return the comma-separated list of nodes, and fix the few places that need a space-separated list to use "| tr ',' ' '" or "${VAR//,/ }" or similar.
It shouldn't be harmful for "comma_list()" to take an already comma-separated list as input, so there isn't a requirement for a single patch to remove the use of comma_list() from all tests, only those few places that require a space-separated list.
Attachments
Activity
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56885/
Subject: LU-12597 tests: remove comma_list for OSTs part 2
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a97234edf1f0fcf04ed7a30fe05796098cb3beb9
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56844/
Subject: LU-12597 tests: remove comma_list for OSTs part 1
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6ea69c3e52923048f837f17160f2984f7596ccde
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56636/
Subject: LU-12597 tests: clean up comma_list in test-framework
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 728d462ba625550f9e255ca34b2411579e9f7379
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56635/
Subject: LU-12597 tests: return comma-separated osts_nodes()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: afe24b136a6af60dae25c03c72b207ce672f8f9b
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57326
Subject: LU-12597 tests: remove comma_list for MDTs part 3
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1603dcb2d8c8f1ae4ffef9b59e173927f532e41d
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57325
Subject: LU-12597 tests: remove comma_list for MDTs part 2
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bb876db9215e7aaf53979feb0fda6b41f0471c7d
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57194
Subject: LU-12597 tests: return comma-separated mdts_nodes()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b69482df6f487dfca2ce40a455af19b0d6ac6829
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57183
Subject: LU-12597 tests: remove comma_list for MDTs part 1
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: edec88b192cf905987f681200a656aa5731f1144
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57132
Subject: LU-12597 tests: remove comma_list for OSTs part 4
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 489b21c9fdee0e16d7c0cd1eb5f4c9f4985898d2
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56909
Subject: LU-12597 tests: remove comma_list for OSTs part 3
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fcdc84a8182d897a446828ea669148c30e295be5
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56909/
Subject: LU-12597 tests: remove comma_list for OSTs part 3
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 87beee4a74076c2c7c3a45ea0c6d42446be63c4f