[LU-12626] Attempt to create existing net returns EINVAL

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
• Labels: llnlfixready
• Severity: 3
• Assignee: Olaf Faaland
• Reporter: Olaf Faaland

Description

When "lnetctl net add" is called for an interface/net pair that already exists, the error code returned is EINVAL. It should be EEXIST, so the user knows that the net is already configured.

[olaf@diane lustre]$ sudo lnet/utils/lnetctl net add --net tcp1 --if enp0s3
[olaf@diane lustre]$ sudo lnet/utils/lnetctl net add --net tcp1 --if enp0s3
add:
    - net:
          errno: -22
          descr: "cannot add network: Invalid argument"

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35953/
Subject: LU-12626 lnet: create existing net returns EEXIST
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 2a59f48ee2bed7f80ae193edaabc67abc3445d0a

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35953
Subject: LU-12626 lnet: create existing net returns EEXIST
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 3a1ef49a40bf6dfac13695dd0ad75abda4bf48d1

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35681/
Subject: LU-12626 lnet: create existing net returns EEXIST
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4aa71267cc0317e126843509f1c5b237f469414b

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35681
Subject: LU-12626 lnet: create existing net returns EEXIST
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 20b8dc05a948505148bd07d51b0b7f55918603ef

[Peter Jones]

Olaf

You've marked this as llnlfixready - does that mean that you'll be pushing the fix?

Peter