Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12692

The maximum quota grace time check is wrong

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Lustre 2.12.2
    • Fix Version/s: None
    • Labels:
      None
    • Epic/Theme:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      According to the the help message, The maximum quota grace time seems to be 2^48 - 1 seconds. But, the upper limit is checked by UINT_MAX. It should be checked by LQUOTA_GRACE_MAX.

      lustre/utils/lfs.c

      int lfs_setquota_times(int argc, char **argv)
{
<snip>
 if ((dqb->dqb_valid | QIF_BTIME && dqi->dqi_bgrace >= UINT_MAX) ||
 (dqb->dqb_valid | QIF_ITIME && dqi->dqi_igrace >= UINT_MAX)) {

       

      # lfs setquota -t -u --block-grace 281474976710655 /lustre/
error: grace time is too large

       

        Attachments

          Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-12280 Provide option to disable soft quota expiration

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

            Activity

              People

              • Assignee:
                takamura Tatsushi Takamura
                Reporter:
                takamura Tatsushi Takamura
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: