[LU-12692] The maximum quota grace time check is wrong

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Affects Version/s: Lustre 2.12.2

Epic/Theme

Quota

• Severity: 3
• Assignee: Tatsushi Takamura
• Reporter: Tatsushi Takamura

Description

According to the the help message, The maximum quota grace time seems to be 2^48 - 1 seconds. But, the upper limit is checked by UINT_MAX. It should be checked by LQUOTA_GRACE_MAX.

lustre/utils/lfs.c

int lfs_setquota_times(int argc, char **argv)
{
<snip>
 if ((dqb->dqb_valid | QIF_BTIME && dqi->dqi_bgrace >= UINT_MAX) ||
 (dqb->dqb_valid | QIF_ITIME && dqi->dqi_igrace >= UINT_MAX)) {

 

# lfs setquota -t -u --block-grace 281474976710655 /lustre/
error: grace time is too large

 

Issue Links

• is related to: LU-12280 Provide option to disable soft quota expiration