Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12737

consolidate argument validation in llog

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Rank (Obsolete):
      9223372036854775807

      Description

      This ticket is to track a cleanup from LU-11566.

      https://review.whamcloud.com/#/c/34523/

      Description:

      LU-11566 llog: consolidate argument validation

      Add a helper function to validate the start/end arguments passed from
      userspace for "lctl llog_cancel" and "lctl llog_print" to reduce code
      duplication.

      The llog callback data is static in these functions, for use by repeat
      calls for each record in the log. This is not really safe, if there
      are multiple threads calling the llog_print or llog_check functions
      concurrently. Fortunately, this is unlikely to be the case, but it
      would be better to allocate them dynamically in the caller.

        Attachments

          Activity

            People

            • Assignee:
              adilger Andreas Dilger
              Reporter:
              pfarrell Patrick Farrell (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: