Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12756

Refactor lnet_select_pathway and lnet_peer_ni ref counting

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Rank (Obsolete):
      9223372036854775807

      Description

      lnet_select_pathway() contains a fair amount of duplicated code. I took a stab at refactoring this function and I believe I have a functionally equivalent implementation with about half as much code.

      During that process I noted that the lnet_nid2peerni_locked() function takes a ref on the lnet_peer_ni
      object that it returns, however most callers of this function do not need this reference as they hold a net lock when referencing the lnet_peer_ni. So some additonal code removal is possible here as well.

        Attachments

          Activity

            People

            • Assignee:
              hornc Chris Horn
              Reporter:
              hornc Chris Horn
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: