[LU-12756] Refactor lnet_select_pathway and lnet_peer_ni ref counting

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

lnet_select_pathway() contains a fair amount of duplicated code. I took a stab at refactoring this function and I believe I have a functionally equivalent implementation with about half as much code.

During that process I noted that the lnet_nid2peerni_locked() function takes a ref on the lnet_peer_ni
object that it returns, however most callers of this function do not need this reference as they hold a net lock when referencing the lnet_peer_ni. So some additonal code removal is possible here as well.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36540/
Subject: LU-12756 lnet: Remove unnecessary rtr_nid argument
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 357fa4a84f4bb0a0b54f176ab8e2d4f59be80bb6

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36540/
Subject: LU-12756 lnet: Remove unnecessary rtr_nid argument
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 01286ba81ce93e05e5e61c8346c80c74deb29d32

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36539/
Subject: LU-12756 lnet: Introduce lnet_msg_is_response
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ef20f5e84e5457397da5b0e086c42ce6b79e2574

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36538/
Subject: LU-12756 lnet: Refactor lnet_find_existing_preferred_best_ni
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ef7c4021c03c6b2b300b9075bf60d2be7d66784a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36537/
Subject: LU-12756 lnet: Refactor lnet_set_non_mr_pref_nid
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ce442253a719a065bf85e0202546a3afd4a38524

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36621/
Subject: LU-12756 lnet: Refactor lnet_compare_routes
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e02287b4ef6a30e9e23a84012d8a133621ea454e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36620/
Subject: LU-12756 lnet: Remove unused vars in lnet_find_route_locked
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b129f7b1f76a716c656627beb271de58e6af473c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36536/
Subject: LU-12756 lnet: Avoid extra lnet_remotenet lookup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3812c54b9ca3cc08be947f893bdf55a41aa876ed

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36535/
Subject: LU-12756 lnet: Avoid comparing route to itself
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2b8d9d12d182fc91d671558434cc0b652c1ade21

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36534/
Subject: LU-12756 lnet: Refactor lnet_find_best_lpni_on_net
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 80edb2ad72baf9b096e03f2929b8b018b0a630d2

[Alexey Lyashkov]

@Chris - my vote to add some performance testing against that series.
As I see, it have touched a sort of hot code. So I think we need to add performance evaluation as similar as we have with MR routing testing.
workload is same for all tests - mdtest + IOR with small record size (4k-8k).
1) new code on server
2) new code on routers also -
3) all nodes have same code.