Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12929

Field net_state in struct lnet_net is never used, only set. It should be discarded

Details

    • Improvement
    • Resolution: Fixed
    • Trivial
    • Lustre 2.14.0
    • None
    • None
    • 9223372036854775807

    Description

      lnet_net.net_state is set, but never used.

      So the code that sets it is never tested, and it isn't clear what it means,.

      So let's just remove it.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-12678 LNet simplification work from linux client

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-12929] Field net_state in struct lnet_net is never used, only set. It should be discarded
            pjones Peter Jones added a comment -

            Landed for 2.14

            pjones Peter Jones added a comment - Landed for 2.14
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36655/
            Subject: LU-12929 lnet: Remove field net_state in struct lnet_net
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: df3904c3486c71da586d43fbfca8f126b5764838

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36655/ Subject: LU-12929 lnet: Remove field net_state in struct lnet_net Project: fs/lustre-release Branch: master Current Patch Set: Commit: df3904c3486c71da586d43fbfca8f126b5764838
            gerrit Gerrit Updater added a comment -

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/36655
            Subject: LU-12929 lnet: Remove field net_state in struct lnet_net
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: fab0bb91ab501c2eb9aaa27c299a4f58920be1c2

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/36655 Subject: LU-12929 lnet: Remove field net_state in struct lnet_net Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fab0bb91ab501c2eb9aaa27c299a4f58920be1c2

            People

              neilb Neil Brown
              neilb Neil Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: