[LU-12930] use schedule_timeout_{un,}interruptible where possible.

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

The construct:

  

set_current_state(TASK_UNINTERRUPTIABLE);
schedule_timeout(time);

Is more clearly expressed as

schedule_timeout_uninterruptible(time);

And similarly with TASK_INTERRUPTIBLE / schedule_timeout_interruptible()

Establishing this practice makes it harder to forget to call set_current_state() as has happened a couple of times - in lnet_peer_discovery and mdd_changelog_fini().

Also, there is no need to set_current_state(TASK_RUNNABLE) after calling schedule*().  That state is guaranteed to have been set.

 

Issue Links

• is related to: LU-12511 Prepare lustre for adoption into the linux kernel
• is related to: LU-9019 Migrate lustre to standard 64 bit time kernel API

Comments

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36656/
Subject: LU-12930 various: use schedule_timeout_*interruptible
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5c883ea2748ae9e430a9cd863a9b630b2a74440a

[James A Simmons]

https://review.whamcloud.com/#/c/36656/