Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12951

LL_IOC_GETOBDCOUNT return wrong MDT counts

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.14.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      We used llapi_get_obd_count() to get MDT/OST counts, which call LL_IOC_GETOBDCOUNT
      internally.

      However, we return lmv->lmv_mdt_descs.ltd_tgts_size as MDT count, this is not right.
      @ltd_tgts_size could be larger than actual MDT count, as we preallocate ltd_tgts and resize it if necessary.

      Attachments

        Issue Links

          Activity

            [LU-12951] LL_IOC_GETOBDCOUNT return wrong MDT counts
            pjones Peter Jones added a comment -

            Landed for 2.14

            pjones Peter Jones added a comment - Landed for 2.14

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36713/
            Subject: LU-12951 lmv: fix to return correct MDT count
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 3aa8826aabc7ceb16ed5efc8606a243684274982

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36713/ Subject: LU-12951 lmv: fix to return correct MDT count Project: fs/lustre-release Branch: master Current Patch Set: Commit: 3aa8826aabc7ceb16ed5efc8606a243684274982
            scherementsev Sergey Cheremencev added a comment - - edited

            Lai pointed to problems at proposed patch https://review.whamcloud.com/#/c/36768/.
            So, please ignore my previous comment.

            scherementsev Sergey Cheremencev added a comment - - edited Lai pointed to problems at proposed patch https://review.whamcloud.com/#/c/36768/ . So, please ignore my previous comment.

            Hello, found this only after sending a patch from LU-12975.

            Suppose to use https://review.whamcloud.com/#/c/36768/ as more general solution.
            It is a regression after "LU-12624 obdclass: lu_tgt_descs cleanup" and ltd_tgts_size should be changed not only in one place.
            Please take a look at my patch.

            Thanks

            Sergey

            scherementsev Sergey Cheremencev added a comment - Hello, found this only after sending a patch from  LU-12975 . Suppose to use  https://review.whamcloud.com/#/c/36768/  as more general solution. It is a regression after " LU-12624  obdclass: lu_tgt_descs cleanup" and ltd_tgts_size should be changed not only in one place. Please take a look at my patch. Thanks Sergey

            Wang Shilong (wshilong@ddn.com) uploaded a new patch: https://review.whamcloud.com/36713
            Subject: LU-12951 LMV: fix to return correct MDT count
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 4531f44834c8492604bcc8e40a9351eba29eda5c

            gerrit Gerrit Updater added a comment - Wang Shilong (wshilong@ddn.com) uploaded a new patch: https://review.whamcloud.com/36713 Subject: LU-12951 LMV: fix to return correct MDT count Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 4531f44834c8492604bcc8e40a9351eba29eda5c

            People

              wshilong Wang Shilong (Inactive)
              wshilong Wang Shilong (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: