[LU-12999] gcc8 compile warning on string overflow in name_create_mdt

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0, Lustre 2.12.7
• Severity: 3
• Assignee: Shaun Tancheff
• Reporter: Shaun Tancheff

Description

 

/home/shaun/lustre-wc-rel/lustre/mgs/mgs_llog.c:1539:2: note: ‘sprintf’ output between 9 and 10 bytes into a destination of size 9
 sprintf(mdt_index, "-MDT%04x", i);
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/shaun/lustre-wc-rel/lustre/mgs/mgs_llog.c:1539:30: error: ‘sprintf’ may write a terminating nul past the end of the destination [-Werror=format-overflow=]
 sprintf(mdt_index, "-MDT%04x", i);
 

 

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43321/
Subject: LU-12999 mgs: Cleanup string handling in name_create_mdt
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: f7a59078e3c37d25b22f90e158f737e26a320b5a

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43321
Subject: LU-12999 mgs: Cleanup string handling in name_create_mdt
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: aeb93ed5868af923096e714c055739ea7a5f646e

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36817/
Subject: LU-12999 mgs: Cleanup string handling in name_create_mdt
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 298cdb5c0b6136b91e76c9c515bfbc2df99bae0b

[Gerrit Updater]

Shaun Tancheff ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36817
Subject: LU-12999 mgs: Increase string buffer in name_create_mdt
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e691efbeafeec6d21ff69b15c7b540ce1d6fc3c9