[LU-13037] print stats for NRS TBF rules

• Type: Improvement
• Resolution: Unresolved
• Priority: Major
• Labels: TBF
• Assignee: Li Xi
• Reporter: Mahmoud Hanafi

Description

We would like a way to dump current tbf stats.
For example print all the UID being tracked and what are each UID bucket usage.

Issue Links

• is related to: LU-17920 Add permanent TBF rules
• is related to: LU-17296 NRS TBF default rules
• is related to: LU-14501 NRS TBF UID: limit per "any" user?

Comments

[Mahmoud Hanafi]

We have been using the patch. But I think it needs addition work to be more useful. We will need to think about how it could improved.

[Peter Jones]

mhanafi jaylan you have not provided any feedback as to whether this patch meets your requirements. However, rumour has it that you are carrying this patch - does this mean that you can now provide us some feedback as to whether this patch is useful and should proceed with landing?

[Peter Jones]

jaylan any updates on testing this patch?

[Qian Yingjin]

I build it based on the latest master branch.
It seems that tc_rpc_rate is __u32, while in 2.12.4, it was __u64

To make it pass the build for 2.12.4, you just need to modify it with:

seq_printf(p, "%llu\n", cli->tc_rpc_rate);

Regards,
Qian

[Jay Lan (Inactive)]

I had compilation error in lustre-2.12.4 against CentOS 7.7 kernel :

Making all in .
/tmp/rpmbuild-lustre-jlan-UDyILlEP/BUILD/lustre-2.12.4/lustre/ptlrpc/nrs_tbf.c: In function 'nrs_tbf_stats_seq_show':
/tmp/rpmbuild-lustre-jlan-UDyILlEP/BUILD/lustre-2.12.4/lustre/ptlrpc/nrs_tbf.c:3882:2: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type '__u64' [-Werror=format=]
seq_printf(p, "%u\n", cli->tc_rpc_rate);
^
/tmp/rpmbuild-lustre-jlan-UDyILlEP/BUILD/lustre-2.12.4/lustre/ptlrpc/nrs_tbf.c: At top level:
cc1: error: unrecognized command line option "-Wno-stringop-overflow" [-Werror]
cc1: error: unrecognized command line option "-Wno-stringop-truncation" [-Werror]
cc1: error: unrecognized command line option "-Wno-format-truncation" [-Werror]
cc1: all warnings being treated as errors
make[7]: *** [/tmp/rpmbuild-lustre-jlan-UDyILlEP/BUILD/lustre-2.12.4/lustre/ptlrpc/nrs_tbf.o] Error 1

I do not know how I got those "unrecgonized command line option". Before applying this patch it was compiled fine.

[Qian Yingjin]

Hi Mahmoud,
I just updated the patch (https://review.whamcloud.com/#/c/36950/), could you please try it again?

Thanks,
Qian

[Li Xi]

mhanafi Sorry for the misunderstanding. I found a bug of the patch. Not sure whether that is the cause of the duplicated outputs. The patch will be refreshed soon anyway.

[Mahmoud Hanafi]

I understand that we have hp and reg. But We get 2 request for the same cpt and queue_type type

 - uid:             929411059
  cpt:             0
  queue_type:      reg
  refs:            1
  rule:            default
--
- uid:             929411059
  cpt:             0
  queue_type:      reg
  refs:            1
  rule:            default
-- 

Yes Peter we would like to get this landed.