[LU-13053] conf-sanity test 87 call to umount_ldiskfs() fails

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Affects Version/s: Lustre 2.13.0, Lustre 2.14.0, Lustre 2.12.4
• Labels: easy tests
• Severity: 3
• Assignee: James Nunez (Inactive)
• Reporter: James Nunez (Inactive)

Description

conf-sanity test_87 calls umount_ldiskfs() and fails to find the function

/usr/lib64/lustre/tests/conf-sanity.sh: line 6334: umount_ldiskfs: command not found

The problem is that umount_ldiskfs() does not exist, but unmount_ldiskfs() does exist. conf-sanity test 87 is the only test and only test suite that calls unmount_ldiskfs().

umount_client() is another function that exists and is used throughout conf-sanity. Since the unmount command is umount, let’s be consistent and change unmount_ldiskfs() to umount_ldiskfs().

Comments

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36949/
Subject: LU-13053 tests: fix conf-sanity call to umount_ldiskfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4cccb265c5c2148cc4d1089fa1bdaa8db606d57e

[James Nunez (Inactive)]

Reviewing all the unmount commands in test-framework, we have the following that use 'umount' in the name:
umount_client()
zconf_umount_clients()

We have the following that use 'unmount' in the name:
unmount_ldiskfs()
unmount_zfs()
unmount_fstype()

It looks like we are being a bit inconsistent in naming conventions between clients and servers.

In the latest version of the patch, I just changed conf-sanity test 87 to conform to what is in test-framework.sh.

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36949
Subject: LU-13053 tests: rename unmount_ldiskfs to umount
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1f24cd0e0c460e0ff2e079ee1ad16d0d71554ab2