Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13157

migrate symlink with target name length > 59 cause crash

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.14.0, Lustre 2.12.5
    • Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      mdd_migrate() allocate 'la_size + 1' for symlink target name, the extra '+1' is a mistake, which will cause read beyond range fault: if target name is 59 bytes long, then it will try to read target name from external block other than inline i_block[15], that's why when target name is shorter than 59 it won't cause any problem.

      Attachments

        Issue Links

          Activity

            [LU-13157] migrate symlink with target name length > 59 cause crash

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38112/
            Subject: LU-13157 mdd: migrate readlink from wrong place
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 6b105dcf5bd3b06881c54a1c5e877cebefc9b67c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38112/ Subject: LU-13157 mdd: migrate readlink from wrong place Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 6b105dcf5bd3b06881c54a1c5e877cebefc9b67c

            Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38112
            Subject: LU-13157 mdd: migrate readlink from wrong place
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: b51d487d16c5a001800afbb3143fb7f724b37439

            gerrit Gerrit Updater added a comment - Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38112 Subject: LU-13157 mdd: migrate readlink from wrong place Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: b51d487d16c5a001800afbb3143fb7f724b37439
            pjones Peter Jones added a comment -

            Landed for 2.14

            pjones Peter Jones added a comment - Landed for 2.14

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37285/
            Subject: LU-13157 mdd: migrate readlink from wrong place
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: a3b30423c6067b3e8644ecfb3269f8837af7e4cd

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37285/ Subject: LU-13157 mdd: migrate readlink from wrong place Project: fs/lustre-release Branch: master Current Patch Set: Commit: a3b30423c6067b3e8644ecfb3269f8837af7e4cd

            Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/37285
            Subject: LU-13157 mdd: extra byte read in symlink migrate
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7e2a5c31f9e231b740a7daf27bf1bd6476bd9b93

            gerrit Gerrit Updater added a comment - Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/37285 Subject: LU-13157 mdd: extra byte read in symlink migrate Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7e2a5c31f9e231b740a7daf27bf1bd6476bd9b93

            People

              laisiyao Lai Siyao
              laisiyao Lai Siyao
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: