[LU-13364] lnetctl: unexpected output for lnetctl import --show

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Labels: easy lnet
• Severity: 3
• Assignee: Cyril Bordage
• Reporter: Amir Shehata (Inactive)

Description

nid entries at the end of the net show is extraneous. They shouldn't be there.

[root@lustre02 ~]# lnetctl import --show < net984481795.yaml
net:
    - net type: lo
      local NI(s):
        - nid: 0@lo
          status: up
    - net type: tcp
      local NI(s):
        - nid: 192.168.122.103@tcp
          status: up
          interfaces:
              0: eth0
        - nid: 192.168.122.104@tcp
          status: up
          interfaces:
              0: eth1
        - nid: 192.168.122.105@tcp
          status: up
          interfaces:
              0: eth2
    - net type: tcp2
      local NI(s):
        - nid: 192.168.122.103@tcp2
          status: up
          interfaces:
              0: eth0
    - net type: tcp3
      local NI(s):
        - nid: 192.168.122.103@tcp3
          status: up
          interfaces:
              0: eth0
    - net type: tcp4
      local NI(s):
        - nid: 192.168.122.103@tcp4
          status: up
          interfaces:
              0: eth0
    - nid: 0@lo
      status: up
    - nid: 0@lo
      status: up

Comments

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/43922/
Subject: LU-13364 utils: fix bad output for lnetctl import --show
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 81e3cc4a56a29d480ac421e64b45f46b6214b73a

[Gerrit Updater]

Cyril Bordage ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43922
Subject: LU-13364 utils: fix bad output for lnetctl import --show
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ca9bfce01f1cda5a8dc26785752d5a79b71e74b

[Cyril Bordage]

Do we need to merge imported config and detected config? Right now, if we have "net" node in imported config, we kind of a merge (with a bad node). Do I need to merge with absent interfaces?