Details
-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
None
-
3
-
9223372036854775807
Description
Do not delete a non-MR peer when it first connects. We should only delete a peer from our local database iff we've already discovered it and it's state is changing from discovery on to discovery off.
I think it is better to do a push to the peers only when discovery is toggled from on to off. This lets the peers know to clear their representation of the node. When it attempts to connect to it after, it'll get the correct list of NIDs.
However in the reverse case; discovery going from off to on, the PUSH can be sent on an interface which is not recorded on the far side. The push is dropped in this case. By not pushing when we go from off to on we avoid this scenario and allow the peer to rediscover when it commences communication.