Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13553

o2iblnd: convert LASSERT (tx->tx_sending > 0); to proper error handling

Details

    • 3
    • 9223372036854775807

    Description

      When a tx completes kiblnd_tx_complete() callback is invoked. We ensure:

      LASSERT (tx->tx_sending > 0);

      However this assert is being triggered in some rare scenarios.

      The reasosn tx_sending would be 0 at this point is because:

      1. ib_post_send() failed but OFED stack is still sending a tx complete event
      2. we're getting two different events for the same tx

      Instead of asserting, it'll be better to ignore that tx_complete event and print some more details on the tx in question.

      Attachments

        Activity

          [LU-13553] o2iblnd: convert LASSERT (tx->tx_sending > 0); to proper error handling
          pjones Peter Jones made changes -
          Link Original: This issue is related to JFC-17 [ JFC-17 ]
          pjones Peter Jones made changes -
          Link New: This issue is related to JFC-20 [ JFC-20 ]
          pjones Peter Jones made changes -
          Labels Original: LTS12
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.12.6 [ 14707 ]
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38752/
          Subject: LU-13553 lnd: gracefully handle unexpected events
          Project: fs/lustre-release
          Branch: b2_12
          Current Patch Set:
          Commit: 89e6bf780e33be2020490b28945a53a6d61b8da0

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38752/ Subject: LU-13553 lnd: gracefully handle unexpected events Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 89e6bf780e33be2020490b28945a53a6d61b8da0
          gerrit Gerrit Updater added a comment -

          Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38752
          Subject: LU-13553 lnd: gracefully handle unexpected events
          Project: fs/lustre-release
          Branch: b2_12
          Current Patch Set: 1
          Commit: 8960fd95ba6cc74b9940105db99ce46389b54d21

          gerrit Gerrit Updater added a comment - Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38752 Subject: LU-13553 lnd: gracefully handle unexpected events Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 8960fd95ba6cc74b9940105db99ce46389b54d21
          pjones Peter Jones made changes -
          Labels New: LTS12
          pjones Peter Jones made changes -
          Link New: This issue is related to JFC-17 [ JFC-17 ]
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.14.0 [ 14490 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.14

          pjones Peter Jones added a comment - Landed for 2.14

          People

            ashehata Amir Shehata (Inactive)
            ashehata Amir Shehata (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: