Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13609

lctl --device MGS llog_catlist doesn't list all config files.

Details

    • 3
    • 9223372036854775807

    Description

      When trying to do a catlist it  is limited to ~304.

      nbp8-mds1 ~ # debugfs -c /dev/mapper/nbp8--vg-mgs8 -R 'ls -l /CONFIGS/'   | wc -l
      debugfs 1.45.2.wc1 (27-May-2019)
      /dev/mapper/nbp8--vg-mgs8: catastrophic mode - not reading inode or group bitmaps
      330
      nbp8-mds1 ~ # lctl --device MGS llog_catlist |wc -l 
      305
      
      nbp2-mds ~ # debugfs -c /dev/mapper/nbp2--vg-mgs2 -R 'ls -l /CONFIGS/'   | wc -l
      debugfs 1.45.2.wc1 (27-May-2019)
      /dev/mapper/nbp2--vg-mgs2: catastrophic mode - not reading inode or group bitmaps
      353
      nbp2-mds ~ # lctl --device MGS llog_catlist |wc -l 
      304
      

      Attachments

        1. debugfs.ls
          23 kB
        2. lctl.ls
          7 kB

        Issue Links

          Activity

            [LU-13609] lctl --device MGS llog_catlist doesn't list all config files.

            Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39330
            Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 43ec5ab5b889b70e73bcd3faedbfca39fbdcc072

            gerrit Gerrit Updater added a comment - Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/39330 Subject: LU-13609 llog: list all the log files correctly on MGS/MDT Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 43ec5ab5b889b70e73bcd3faedbfca39fbdcc072
            pjones Peter Jones added a comment -

            Landed for 2.14

            pjones Peter Jones added a comment - Landed for 2.14

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38917/
            Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 1d97a8b4cd3de9074f323332c7b736367a70d419

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38917/ Subject: LU-13609 llog: list all the log files correctly on MGS/MDT Project: fs/lustre-release Branch: master Current Patch Set: Commit: 1d97a8b4cd3de9074f323332c7b736367a70d419

            Hi Peter,

            I understood. My notes was a reminder that the new patch to master branch can not be applied clearnly to b2_12.

            Thanks, Jay

            jaylan Jay Lan (Inactive) added a comment - Hi Peter, I understood. My notes was a reminder that the new patch to master branch can not be applied clearnly to b2_12. Thanks, Jay
            pjones Peter Jones added a comment -

            Jay

            Naturally but as per the standard we'll finalize the fix for master first

            Peter

            pjones Peter Jones added a comment - Jay Naturally but as per the standard we'll finalize the fix for master first Peter

            We would need a back port to b2_12 when the patch is ready. Thanks.

            jaylan Jay Lan (Inactive) added a comment - We would need a back port to b2_12 when the patch is ready. Thanks.

            Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38917
            Subject: LU-13609 llog: list all the log files correctly on MGS/MDT
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 77f088f1d0c70ada7ecbee082ec5b2f27269fb8f

            gerrit Gerrit Updater added a comment - Emoly Liu (emoly@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38917 Subject: LU-13609 llog: list all the log files correctly on MGS/MDT Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 77f088f1d0c70ada7ecbee082ec5b2f27269fb8f
            emoly.liu Emoly Liu added a comment -

            mhanafi,

            You are right. This limit (7616 bytes) is from the user data buffer:

            int jt_llog_catlist(int argc, char **argv)
            {
                    struct obd_ioctl_data data;
                    char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf; #MAX_IOC_BUFLEN=8192
                    int rc;
            
                    if (argc != 1)
                            return CMD_HELP;
            
                    memset(&data, 0, sizeof(data));
                    data.ioc_dev = cur_device;
                    data.ioc_inllen1 = sizeof(rawbuf) - __ALIGN_KERNEL(sizeof(data), 8);
            

            I will fix it.

            emoly.liu Emoly Liu added a comment - mhanafi , You are right. This limit (7616 bytes) is from the user data buffer: int jt_llog_catlist(int argc, char **argv) { struct obd_ioctl_data data; char rawbuf[MAX_IOC_BUFLEN], *buf = rawbuf; #MAX_IOC_BUFLEN=8192 int rc; if (argc != 1) return CMD_HELP; memset(&data, 0, sizeof(data)); data.ioc_dev = cur_device; data.ioc_inllen1 = sizeof(rawbuf) - __ALIGN_KERNEL(sizeof(data), 8); I will fix it.
            emoly.liu Emoly Liu added a comment -

            The following files were missed by lctl command:

                940  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST000d
                977  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0044
               1027  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0048
                798  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST004f
               1031  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0062
                942  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST0075
                854  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0087
                981  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST00ac
                945  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST00c3
                990  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST00e1
               1093  100644 (1)      0      0   14792 26-Oct-2014 23:37 nbp8-OST00e9
                888  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST00f2
                836  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0108
                845  100644 (1)      0      0   14792 26-Oct-2014 23:34 nbp8-OST0109
                938  100644 (1)      0      0   14792 26-Oct-2014 23:35 nbp8-OST0110
               1017  100644 (1)      0      0   14792 26-Oct-2014 23:36 nbp8-OST0117
               1044  100644 (1)      0      0   14792 26-Oct-2014 23:37 nbp8-OST0133
                 14  100644 (1)      0      0       0  5-Jun-2013 21:11 _mgs-sptlrpc
                329  100644 (1)      0      0   61600  2-Jun-2015 08:53 params
                 16  100644 (1)      0      0    8192 30-Oct-2018 04:38 nodemap
                 17  100644 (1)      0      0       0 20-Aug-2019 09:29 obdfilter-client
                 13  100644 (1)      0      0   12288 13-Dec-2018 23:00 mountdata
            

            I will have a check.

            emoly.liu Emoly Liu added a comment - The following files were missed by lctl command: 940 100644 (1) 0 0 14792 26-Oct-2014 23:35 nbp8-OST000d 977 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST0044 1027 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST0048 798 100644 (1) 0 0 14792 26-Oct-2014 23:34 nbp8-OST004f 1031 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST0062 942 100644 (1) 0 0 14792 26-Oct-2014 23:35 nbp8-OST0075 854 100644 (1) 0 0 14792 26-Oct-2014 23:34 nbp8-OST0087 981 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST00ac 945 100644 (1) 0 0 14792 26-Oct-2014 23:35 nbp8-OST00c3 990 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST00e1 1093 100644 (1) 0 0 14792 26-Oct-2014 23:37 nbp8-OST00e9 888 100644 (1) 0 0 14792 26-Oct-2014 23:35 nbp8-OST00f2 836 100644 (1) 0 0 14792 26-Oct-2014 23:34 nbp8-OST0108 845 100644 (1) 0 0 14792 26-Oct-2014 23:34 nbp8-OST0109 938 100644 (1) 0 0 14792 26-Oct-2014 23:35 nbp8-OST0110 1017 100644 (1) 0 0 14792 26-Oct-2014 23:36 nbp8-OST0117 1044 100644 (1) 0 0 14792 26-Oct-2014 23:37 nbp8-OST0133 14 100644 (1) 0 0 0 5-Jun-2013 21:11 _mgs-sptlrpc 329 100644 (1) 0 0 61600 2-Jun-2015 08:53 params 16 100644 (1) 0 0 8192 30-Oct-2018 04:38 nodemap 17 100644 (1) 0 0 0 20-Aug-2019 09:29 obdfilter-client 13 100644 (1) 0 0 12288 13-Dec-2018 23:00 mountdata I will have a check.

            See attached listinglctl.ls

            mhanafi Mahmoud Hanafi added a comment - See attached listing lctl.ls
            emoly.liu Emoly Liu added a comment - - edited

            mhanafi,

            Could you please save the output list of debugfs and lctl respectively, and upload them here? I want to see which files are not showed by "lctl --device MGS llog_catlist"?

            Thanks.

            emoly.liu Emoly Liu added a comment - - edited mhanafi , Could you please save the output list of debugfs and lctl respectively, and upload them here? I want to see which files are not showed by "lctl --device MGS llog_catlist"? Thanks.

            People

              emoly.liu Emoly Liu
              mhanafi Mahmoud Hanafi
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: