[LU-13756] qmt_pool_lock leak in qmt_pool_lookup()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Sergey Cheremencev
• Reporter: Oleg Drokin

Description

It seems that qmt_pool_lookup() jumps to out_err label if qti_pools_add() fails, but the pool lock is not released:

out_err:
        CERROR("%s: cannot add pool %s: err = %d\n",
                qmt->qmt_svname, pos->qpi_name, rc);
        RETURN(ERR_PTR(rc));

seems like a bug?
Introduced by 09f9fb3211c "LU-11023 quota: quota pools for OSTs"

Issue Links

• is related to: LU-11023 OST Pool Quotas

Comments

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/45106/
Subject: LU-13756 quota: up_read leak in qmt_pool_lookup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d16b3141119a3b75276914ad3601e0dd27579b2b

[Gerrit Updater]

"Sergey Cheremencev <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45106
Subject: LU-13756 quota: up_read leak in qmt_pool_lookup
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 71fe6dd27278df3ca01e0516da3242cf5c81513a