[LU-13767] potentially unsace spec check in mdd_object_make_hint()

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Affects Version/s: Lustre 2.14.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

in mdd_object_make_hint we have this code:

        if (S_ISDIR(attr->la_mode) &&
            unlikely(spec != NULL && spec->sp_cr_flags & MDS_OPEN_HAS_EA)) {
                hint->dah_eadata = spec->u.sp_ea.eadata;
                hint->dah_eadata_len = spec->u.sp_ea.eadatalen;
        } else {
                hint->dah_eadata = NULL;
                hint->dah_eadata_len = 0;
                if (spec->sp_cr_flags & MDS_OPEN_APPEND) {

where we assume spec could be NULL but a bit later we also assume it cannot.

probably need to check in both or neither cases?