[LU-13769] osd_dir_it_key and osd_index_it_key feed zap_cursor_retrieve return to ERR_PTR

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Affects Version/s: Lustre 2.14.0
• Labels: smatch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

it looks like both do

       if ((rc = -zap_cursor_retrieve(it->ozi_zc, za)))
                RETURN(ERR_PTR(rc));

But in fact it could return a wildly positive value that would break ERR_PTR as advised by smatch?