[LU-13787] Build failure libcfs needed by snmp

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Labels: llnl
• Environment: Centos 7.8 TOSS 3.6-3 (RHEL 7.8)
• Severity: 3
• Assignee: James A Simmons
• Reporter: Gian-Carlo Defazio

Description

Lustre fails to build while in the snmp directory with the error

make[3]: *** No rule to make target `../libcfs/libcfs/libcfs.la', needed by `liblustresnmp.la'.  Stop.

This can be fixed by just changing the build order in autoMakefile.am by putting libcfs before snmp for both SUBDIRS and DIST_SUBDIRS. However, I don't get a build failure for Centos 7.7, and I don't see everyone's builds failing here, so I suspect I'm not really understanding the problem. Also libcfs came before snmp until change 37971.

So the questions are:

Is there some other reason why the build is failing that explains why it doesn't fail for other environments?

Is there a reason that the build order was changed, putting snmp before libcfs?

Comments

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39388/
Subject: LU-13787 build: fix snmp / libcfs build order
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fb01543905d3d1bd579338b3f280d02b22f6aec3

[Gian-Carlo Defazio]

I was able to get it to fail with only a single make thread, but on Centos 7.8. Thanks for the fix.

[James A Simmons]

I can reproduce this only on Ubuntu20 with make -j X so its a rare corner case for the build system. Easy fix. Sorry it was my OCD for ordering things that broke this.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39388
Subject: LU-13787 build: fix snmp / libcfs build order
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 345ef7a0722b9e73ccfa03d6b4e6cb949ea02cf1

[Andreas Dilger]

Gian-Carlo, I'm not aware of any reason that the order of these lines were changed, but I've added James to the CC list here to get his feedback.

Feel free to submit a patch that reverts to the original order in autoMakefile.am with a label:

Fixes: 742897a967cf ("LU-13274 uapi: make lnet UAPI headers C99 compliant")

and add James and me as reviewers.

If this fixes your build issue and does not break any of the Jenkins builds, then there shouldn't be any problem to land it. James is generally very responsive, so I'm sure he'll comment if there was a good reason for the change.

[John Hammond]

Let's delete the snmp directory and see if anyone notices.