[LU-13841] error messages need additional explanation for lctl pcc commands

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Affects Version/s: Lustre 2.14.0
• Environment: Virtual machine
• Severity: 3
• Assignee: WC Triage
• Reporter: Vikentsi Lapa

Description

 

From user  perspective:

• different cases reports same error. 
• error message itself does not explain what File exists, so it should be documented or changed. Also error message assumed that user knows PCC internals to understand it.

 

From my point of view this can fixed by added some notes or explanation to documentation, or change error message itself, like "cache already enabled for ..."

 

Steps to reproduce:

Directory  for cache is created and exists.

1. ls /mnt/pcc2

#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=2"

Try to add pcc cache multiple times with same rwid

#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=2"

lctl pcc pcc: error: setting llite.lustre-ffff8b405721f800.pcc='add /mnt/pcc2 projid={100} rwid=2': File exists (17)

 

Try to add pcc cache with same path to /mtn/pcc2 but with  with different rwid

[#  lctl pcc add /mnt/lustre /mnt/pcc2 --param "projid={100} rwid=5"

lctl pcc pcc: error: setting llite.lustre-ffff8b405721f800.pcc='add /mnt/pcc2 projid={100} rwid=5*': File exists (17)*

 

Use incorrect arguments: to get path with numbers

1. lctl pcc add /mnt/lustre pccro --param projid={100} rwid=2
   add: must specify mount path and PCC path 3:6
   Add a PCC backend to a client.
   usage: lctl pcc add <mntpath> <pccpath> [--param|-p <param>]
   mntpath: Lustre mount point.
   pccpath: Path of the PCC backend.
   param: Setting parameters for PCC backend.

 What is "PCC path 3:6" about? Similar to lctl pcc del

lctl pcc del /mnt/pcc2
del: must speficy mount path and PCC path 1:2
Delete the specified PCC backend on a client.
usage: clt pcc del <mntpath> <pccpath>

 

Typo in error mesage:

del: must speficy mount path and PCC path 1:2  -> specify

 

Incorrect number of arguments in help output:

1. lctl pcc list
   list: require 2 arguments
   List all PCC backends on a client.
   usage: lctl pcc list <mntpath>**Command output shows 2 arguments in help but only one is required.

 

Issue Links

• is related to: LU-10499 Readonly Persistent Client Cache support

Comments

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52241
Subject: LU-13841 osc: make transfer_page_init called for DIO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4c8c701c29885f537b950e368c82e799a848c01d

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52240
Subject: LU-13841 clio: add cdp_count
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d964e0636036f3f60ba48066df8cec9ecb010d94

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52239
Subject: LU-13841 osc: make transfer_page_init take an otp
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8a47d61b4cd9ef1a6ad9084d77ebb3eedce1f523

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52182
Subject: LU-13841 osc: simplify osc_dio_page_submit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 06011474f68d4985ca5c97f21897b3491b1af5a2

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52167
Subject: LU-13841 osc: add osc_dio_completion
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ef54bbb5d39332edb9c9e9bb539674a50505f48

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52165
Subject: LU-13841 clio: add osc_dio_pages_init
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ff20153b02afd9665b7a88e95f6f9f8d80de465

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52164
Subject: LU-13841 osc: reduce usage of cdp_cl_pages array
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a32e30f37994a148596906a614e4623db381bad3

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52163
Subject: LU-13841 osc: test assert
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0241a815153daf20ffbccc9fb24c539dd51f38b6

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52161
Subject: LU-13841 osc: reduce queue use in __osc_dio_submit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ab05cd1b3a181e600f0d827a032f07a5705377f4

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52159
Subject: LU-13841 osc: convert from list to array
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 646215a9723648cce5257443b2d02222656dd13b

[Gerrit Updater]

"Patrick Farrell <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52112
Subject: LU-13841 clio: rename 'cl_page_completion'
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: efb96a2d7fc55217bb90c8f482a9b90a95e1f134