Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-1402

cfs_alloc_flags_to_gfp should translate CFS_ALLOC_HIGH to __GFP_HIGHMEM instead of __GFP_HIGH

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.3.0
    • None
    • None
    • 3
    • 22,135
    • 4596

    Description

      According to the comment above CFS_ALLOC_HIGH, the flag allows allocator to return memory in the highmen zone:
      /* allow to return page beyond KVM. It has to be mapped into KVM by

      • cfs_page_map(); */

      But cfs_alloc_flags_to_gfp() converts it to __GFP_HIGH, which according to kernel header:
      #define __GFP_HIGH 0x20 /* Should access emergency pools? */

      I think __GFP_HIGHMEM should be used instead. Also it makes sense to rename CFS_ALLOC_HIGH to CFS_ALLOC_HIGHMEM to avoid further confusion.

      Attachments

        Issue Links

          Activity

            People

              di.wang Di Wang (Inactive)
              isaac Isaac Huang (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: