[LU-14158] lfs changelog do not display old changelog after changelog_catalog wrapped arround

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Affects Version/s: Lustre 2.13.0, Lustre 2.12.3, Lustre 2.14.0, Lustre 2.12.4, Lustre 2.12.5
• Environment: VMs + ldiskfs
• Severity: 3
• Assignee: Etienne Aujames
• Reporter: Etienne Aujames

Description

The following source code introduce an regression when the "changelog_catalog" reach the end of llog catalog:

284 static int chlg_load(void *args)                                                                     
285 {                                                                                                    
.....                                                                                     
293                                                                                                      
294         crs->crs_last_catidx = -1;  <-----                                                                
295         crs->crs_last_idx = 0;
.....
332         rc = llog_cat_process(NULL, llh, chlg_read_cat_process_cb, crs,
333                                 crs->crs_last_catidx, crs->crs_last_idx);

The -1 value or LLOG_CAT_FIRST for startcat is special value that scan the a llog catalog from index 0 to lgh_last_idx. It will not process catalog records at the end of catalog if the catalog has wrapped arround ( from llh_cat_idx to the end of catalog indexes). See llog_cat_process_or_fork for more information.

So when the message "llog_cat_process_or_fork: catlog "DFID" crosses index zero" by changelogs client, the client will "lost" all the old changelogs that was not synchronized.

The polling mode is not concerned by this issue (only the first iteration).

I  reproduced this bug on my VMs. I am attaching to this ticket the changelogs files that I used for my tests.

Comments

[Gerrit Updater]

Etienne AUJAMES ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41173
Subject: LU-14158 mdc: process changelogs_catalog from the oldest rec
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 551f775afd14bccf88a847c0f20c899a68b08ff4

[Gerrit Updater]

Etienne AUJAMES ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41132
Subject: LU-14158 tests: process changelogs_catalog from the oldest rec
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 76fa09d6b36090871228d61041d08fdae41b1f01

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40786/
Subject: LU-14158 mdc: process changelogs_catalog from the oldest rec
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ad4c8633498848c2f388942916830b021b5ba350

[Gerrit Updater]

Etienne AUJAMES ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40786
Subject: LU-14158 mdc: process changelogs_catalog from the oldest rec
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c94397960f105fc70e5f6e5c38eb4664bd6976ee