[LU-14352] Only use wake_up_all when necessary

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

wake_up_all() is only needed when there are threads doing an exclusive wait.

wake_up() will wake up all non-exclusive threads, and at most one exclusive thread.  When non-exclusive waits are used, it is sufficient and preferred to use wake_up() to  wake them up.

wake_up_all() should be reserved for those cases where threads are waiting exclusively, and they all want to be woken up.  Keeping it for the purpose only improve code readability.

 

Issue Links

• is related to: LU-12511 Prepare lustre for adoption into the linux kernel

Comments

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41289/
Subject: LU-14352 various: only use wake_up_all() on exclusive waitqs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1f4e9f0f4f483dc93cbecdc841740bc11ec59a73

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41289
Subject: LU-14352 various: only use wake_up_all() on exclusive waitqs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2187f483d7441d368c343e02b634fa6c498b97c9