Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-14352

Only use wake_up_all when necessary

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.15.0
    • None
    • None
    • 9223372036854775807

    Description

      wake_up_all() is only needed when there are threads doing an exclusive wait.

      wake_up() will wake up all non-exclusive threads, and at most one exclusive thread.  When non-exclusive waits are used, it is sufficient and preferred to use wake_up() to  wake them up.

      wake_up_all() should be reserved for those cases where threads are waiting exclusively, and they all want to be woken up.  Keeping it for the purpose only improve code readability.

       

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-12511 Prepare lustre for adoption into the linux kernel

          • Major - Major loss of function.
          • Open

          Activity

            [LU-14352] Only use wake_up_all when necessary
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.15.0 [ 14791 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            simmonsja James A Simmons made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Neil Brown [ neilb ]
            simmonsja James A Simmons made changes -
            Link New: This issue is related to LU-12511 [ LU-12511 ]
            neilb Neil Brown created issue -

            People

              neilb Neil Brown
              neilb Neil Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: