[LU-14654] Need to check if lnet_recovery_limit is non-zero in lnet_peer_ni_add_to_recoveryq_locked()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

Bug in 'cc27201a76 LU-13569 lnet: Age peer NI out of recovery' https://review.whamcloud.com/39718

If lnet_recovery_limit is 0 then we're supposed to allow for indefinite recovery of peer NIs. However, we don't check for this in lnet_peer_ni_add_to_recoveryq_locked():

        if (now > lpni->lpni_last_alive + lnet_recovery_limit) {
                CDEBUG(D_NET, "lpni %s aged out last alive %lld\n",
                       libcfs_nid2str(lpni->lpni_nid),
                       lpni->lpni_last_alive);
                return;
        }

We just need to modify this condition to check whether lnet_recovery_limit is zero/non-zero.

Issue Links

• is related to: LU-17519 Remove dead peers automatically