[LU-14654] Need to check if lnet_recovery_limit is non-zero in lnet_peer_ni_add_to_recoveryq_locked()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Chris Horn
• Reporter: Chris Horn

Description

Bug in 'cc27201a76 LU-13569 lnet: Age peer NI out of recovery' https://review.whamcloud.com/39718

If lnet_recovery_limit is 0 then we're supposed to allow for indefinite recovery of peer NIs. However, we don't check for this in lnet_peer_ni_add_to_recoveryq_locked():

        if (now > lpni->lpni_last_alive + lnet_recovery_limit) {
                CDEBUG(D_NET, "lpni %s aged out last alive %lld\n",
                       libcfs_nid2str(lpni->lpni_nid),
                       lpni->lpni_last_alive);
                return;
        }

We just need to modify this condition to check whether lnet_recovery_limit is zero/non-zero.

Issue Links

• is related to: LU-17519 Remove dead peers automatically

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43502/
Subject: LU-14654 tests: Ensure recovery_limit zero works as expected
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8d1895f2f69bd2eec3ff6af5eb356740fa2c8766

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43501/
Subject: LU-14654 lnet: Correct peer NI recovery age out calculation
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8f3f0e1219724d6e0ed727e46b28ab28203aef9f

[Gerrit Updater]

Chris Horn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43502
Subject: LU-14654 tests: Ensure recovery_limit zero works as expected
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3c24633b629810746fff324271e801a71523ea36

[Gerrit Updater]

Chris Horn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43501
Subject: LU-14654 lnet: Correct peer NI recovery age out calculation
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4e59c31083674ab082476699133a80d7a6e23e65