Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-14703

Fix mismatched lustre-libcfs.m4 comments

Details

    • 9223372036854775807

    Description

      Several macros whose ends are commented to identify the macro being defined, have the wrong macro named in the comment. For example,

      AC_DEFUN([LIBCFS_RHASHTABLE_WALK_INIT_3ARG], [
      LB_CHECK_COMPILE([if 'rhashtable_walk_init' has 3 args],
      rhashtable_walk_init, [
              #include <linux/gfp.h>
              #include <linux/rhashtable.h>
      ],[
              rhashtable_walk_init(NULL, NULL, GFP_KERNEL);
      ],[
              AC_DEFINE(HAVE_3ARG_RHASHTABLE_WALK_INIT, 1,
                      [rhashtable_walk_init() has 3 args])
      ])
      ]) # LIBCFS_RHASHTABLE_REPLACE
      

      These are presumably copy-and-paste errors.

      Attachments

        Activity

          [LU-14703] Fix mismatched lustre-libcfs.m4 comments
          pjones Peter Jones added a comment -

          landed for 2.15

          pjones Peter Jones added a comment - landed for 2.15

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43776/
          Subject: LU-14703 build: fixup lustre-libcfs.m4 comments
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 1b8d85fffb48032de1f828b851672dff9014e91a

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43776/ Subject: LU-14703 build: fixup lustre-libcfs.m4 comments Project: fs/lustre-release Branch: master Current Patch Set: Commit: 1b8d85fffb48032de1f828b851672dff9014e91a

          Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/43776
          Subject: LU-14703 build: fixup lustre-libcfs.m4 comments
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 60d0c018f80dc0b6a474e61bd3b571250538e745

          gerrit Gerrit Updater added a comment - Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/43776 Subject: LU-14703 build: fixup lustre-libcfs.m4 comments Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 60d0c018f80dc0b6a474e61bd3b571250538e745

          People

            ofaaland Olaf Faaland
            ofaaland Olaf Faaland
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: