[LU-15013] potential null pointer access in osc_prep_async_page

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Affects Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: James A Simmons
• Reporter: Oleg Drokin

Description

Introduced by https://review.whamcloud.com/44338

 

        while (--max_scans > 0 &&
               (cli = list_first_entry_or_null(&cache->ccc_lru,
                                               struct client_obd,
                                               cl_lru_osc)) != NULL) {
...
                }
        }
        spin_unlock(&cache->ccc_lru_lock);out:
        cl_env_put(env, &refcheck);
        CDEBUG(D_CACHE, "%s: cli %p freed %ld pages.\n",
                cli_name(cli), cli, rc); 

So now once that cli is NULL we exit and cli_name dereference will get us if +cache is in the debug flags.

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44966/
Subject: LU-15013 osc: use original cli for osc_lru_reclaim for debug msg
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3c6a1e94c652685fac7c69bf530e05d27b7f477c

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/44966
Subject: LU-15013 osc: use original cli for osc_lru_reclaim for debug msg
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3f7f4b722b4bbcaa4f0fdf5bd1fbc58f00a0604d

[James A Simmons]

Oh I can do a quick fix.

[Peter Jones]

James

Can this be fixed in place quickly or should we revert the change?

Peter