[LU-15038] mgc_fs_setup() can leak cl_mgc_mutex reference

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Andreas Dilger (Inactive)
• Reporter: Andreas Dilger (Inactive)

Description

It is possible for mgc_fs_setup() to leak a reference to cl_mgc_mutex if local_oid_storage_init() fails:

        /* The mgc fs exclusion mutex. Only one fs can be setup at a time. */
        mutex_lock(&cli->cl_mgc_mutex); 
        
        /* Setup the configs dir */
        fid.f_seq = FID_SEQ_LOCAL_NAME;
        fid.f_oid = 1;
        fid.f_ver = 0;
        rc = local_oid_storage_init(env, lsi->lsi_dt_dev, &fid,
                                    &cli->cl_mgc_los);
        if (rc)
                RETURN(rc);

Issue Links

• is duplicated by: LU-6554 missing mutex unlock in mgc_fs_setup()
• is related to: LU-19046 server mount stuck uninterruptibly in mgc_fs_setup()