[LU-15038] mgc_fs_setup() can leak cl_mgc_mutex reference

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Andreas Dilger
• Reporter: Andreas Dilger

Description

It is possible for mgc_fs_setup() to leak a reference to cl_mgc_mutex if local_oid_storage_init() fails:

        /* The mgc fs exclusion mutex. Only one fs can be setup at a time. */
        mutex_lock(&cli->cl_mgc_mutex); 
        
        /* Setup the configs dir */
        fid.f_seq = FID_SEQ_LOCAL_NAME;
        fid.f_oid = 1;
        fid.f_ver = 0;
        rc = local_oid_storage_init(env, lsi->lsi_dt_dev, &fid,
                                    &cli->cl_mgc_los);
        if (rc)
                RETURN(rc);

Issue Links

• is duplicated by: LU-6554 missing mutex unlock in mgc_fs_setup()

Comments

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/45063/
Subject: LU-15038 mgc: release cl_mgc_mutex on error
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7cf10b90d62256aa4d177486ff13bd61dfb9a5ff

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45063
Subject: LU-15038 mgc: release cl_mgc_mutex on error
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1389ac82ad805b411bf4b063fb9469cf8c496ed2