Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-1507

Fix confusing code in obd_connect_data

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • None
    • None
    • 3
    • 10605

      ocd_blocksize should actually be called ocd_blockbits. Similarly, ocd_inodespace should be called ocd_inodebits, and fed_pagesize should be called fed_pagebits, and ddp_inodespace called ddp_inodebits, since they are all log2 of the actual device size.
      This further exposes another bug in the OFD code, that ddp_inodespace is used as a "size" in ofd_recovery_complete(), ofd_grant_chunk(), and ofd_grant_create(), instead of a log2 shift when computing the reserved space for inode precreation. Same in both the ldiskfs and ZFS osd_conf_get() implementations.

            wc-triage WC Triage
            jay Jinshan Xiong (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: