Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-15233

Remove extraneous call to cl_page_delete

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • None
    • 9223372036854775807

    Description

      LU-5108 / https://review.whamcloud.com/#/c/10458/ / b117bc837c02e2d156bb114142a28a184aa9d633 added a call to cl_page_delete to the page discard code used by the OSC lru shrinker.

      This seems to have been a mistake.  cl_page_discard causes page invalidation, which calls ll_invalidatepage, which calls cl_page_delete if the page can be found.

      Since the page is locked here and ll_invalidatepage checks for the page (checking that the result of cl_vmpage_page != NULL), this has probably never caused an issue.  But it's extraneous and kind of weird, and misled me a bit when working on another bug.

      Attachments

        Activity

          People

            paf0186 Patrick Farrell (Inactive)
            paf0186 Patrick Farrell (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: