[LU-15588] osd_trans_stop() misses th_sync flag set in top thandle

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Severity: 3
• Assignee: Vladimir Saveliev
• Reporter: Vladimir Saveliev

Description

exp_need_sync flag of obd_export is supposed to provide blocking of
modifying rpc processing until mount's update to last_rcvd is
committed.

It does not do so for mdt:

osd_trans_stop() {
    ...
    dt_txn_hook_stop(, struct thandle *th) {
        if (th->th_top != NULL)
            dtc_th = th->th_top;
        cb->dtc_txn_stop(dtc_th); /* th_sync of top thandle gets set in tgt_last_rcvd_update called below */
    }

    hdl->h_sync = th->th_sync; /* th_sync is taken from sub thandle */
}

As result, ldiskfs_journal_stop() does not do commit.

Issue Links

• is related to: LU-14708 updates to last_rcvd on new client connect and disconnect should be synchronous

Comments

[Gerrit Updater]

"Vladimir Saveliev <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46596
Subject: LU-15588 obdclass: transfer th_sync flag to sub thandle
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 80bc51e7884d270dacc2c0aeba150079ad4dec36