[LU-15591] ext2fs_open2() missing goto

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In e2fsprogs ext2fs_open2() there is a missing goto cleanup after retval = EXT2_ET_SB_CSUM_INVALID. And probably after retval = EXT2_ET_UNKNOWN_CSUM;.

        if (!(fs->flags & EXT2_FLAG_IGNORE_CSUM_ERRORS)) {
                retval = 0;
                if (!ext2fs_verify_csum_type(fs, fs->super))
                        retval = EXT2_ET_UNKNOWN_CSUM;
                if (!ext2fs_superblock_csum_verify(fs, fs->super)) {
                        if (csum_retries++ < 3)
                                goto retry;
                        retval = EXT2_ET_SB_CSUM_INVALID;
                }
        }

Also I find it strange that we check the super block magic after verifying the checksum.

Issue Links

• is related to: LU-15590 e2fsprogs direct IO raw_read_blk() issues