[LU-15800] Fallocate causes transaction deadlock

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.4
• Labels: ost
• Severity: 3
• Assignee: Arshad Hussain
• Reporter: Andriy Skulysh

Description

PID: 74368  TASK: ffff9600eaeac740  CPU: 9   COMMAND: "ll_ost_io02_069"
 #0 [ffffa3f1a7a57830] __schedule at ffffffff9034e1d4
 #1 [ffffa3f1a7a578c8] schedule at ffffffff9034e648
 #2 [ffffa3f1a7a578d8] rwsem_down_read_slowpath at ffffffff903511d0
 #3 [ffffa3f1a7a57978] osd_read_lock at ffffffffc1a3379d [osd_ldiskfs]
                                <--     rc = dt_trans_start_local(env, ofd->ofd_osd , th);
                                        ofd_read_lock(env, ofd_obj);
 #4 [ffffa3f1a7a57998] ofd_write_attr_set at ffffffffc186b6cc [ofd]
 #5 [ffffa3f1a7a57a00] ofd_commitrw_write at ffffffffc186c812 [ofd]
 #6 [ffffa3f1a7a57aa0] ofd_commitrw at ffffffffc18721f1 [ofd]
 #7 [ffffa3f1a7a57b60] finish_wait at ffffffff8fb2e5ac
 #8 [ffffa3f1a7a57bd8] tgt_brw_write at ffffffffc1255544 [ptlrpc]

PID: 73559  TASK: ffff9601653a97c0  CPU: 11  COMMAND: "ll_ost02_046"
 #0 [ffffa3f1a0817970] __schedule at ffffffff9034e1d4
 #1 [ffffa3f1a0817a08] schedule at ffffffff9034e648
 #2 [ffffa3f1a0817a18] wait_transaction_locked at ffffffffc0ad2089 [jbd2]
 #3 [ffffa3f1a0817a68] add_transaction_credits at ffffffffc0ad21c4 [jbd2]
 #4 [ffffa3f1a0817ac0] start_this_handle at ffffffffc0ad250a [jbd2]
 #5 [ffffa3f1a0817b40] jbd2__journal_restart at ffffffffc0ad2ad0 [jbd2]
 #6 [ffffa3f1a0817b80] osd_fallocate_preallocate at ffffffffc1a5b6d2 [osd_ldiskfs]
 #7 [ffffa3f1a0817c18] osd_fallocate at ffffffffc1a5b98d [osd_ldiskfs]
                        <--     ofd_trans_start(env, ofd, fo, th);
                                ofd_write_lock(env, fo);
 #8 [ffffa3f1a0817c50] ofd_object_fallocate at ffffffffc18682f9 [ofd]
 #9 [ffffa3f1a0817cb8] ofd_fallocate_hdl at ffffffffc185912f [ofd]
#10 [ffffa3f1a0817d50] tgt_request_handle at ffffffffc1256a53 [ptlrpc]

The deadlock was added by :

 Commit:         93f700ca241a98630fc5ff19a041e35fbdbf0385
 Author:         Arshad Hussain <[e-mail]>
 Committer:      Oleg Drokin <[e-mail]>
 Author Date:    Thu 10 Sep 2020 02:18:13 AM EEST
 Committer Date: Thu 29 Oct 2020 06:28:42 AM EET

 LU-13765 osd-ldiskfs: Extend credit correctly for fallocate

Issue Links

• is duplicated by: LU-16966 ofd_object_fallocate dead lock?
• is related to: LU-13765 ldiskfs_mb_mark_diskspace_used:3472: aborting transaction: error 28 in __ldiskfs_handle_dirty_metadata
• is related to: LU-14214 incorrect locking in ofd_object_fallocate()